search

rehanone / puppet-samba

Apache License 2.0
5 stars 7 forks source link

'ntlm auth' is not a boolean #39

Closed bschonec closed 8 months ago

bschonec commented 9 months ago

From the Samba Docs, ntlm auth configuration CAN be yes/no but also can be one of the following values:

The source code shows that the config is a boolean and it should be changed to either a string, or (preferable) a

Variant[Enum['ntlmv1-permitted', 'ntlmv2-only', 'mschapv2-and-ntlmv2-only', 'disabled'], Boolean]

40

rehanone commented 9 months ago

Thanks for providing the information about this. I unfortunately don't find much time working on this module so it may be long time before I get a chance to update it. A PR for this change would be more than welcome.

Sorry didn't see that you already have created the PR. Will review it soon.

bschonec commented 9 months ago

Any chance you'd be willing to transfer ownership of the project? Your module is used by a lot of VoxPupuli users. I'd be willing to take over the project if you're willing; I've already made a lot of changes that I intend to submit.

rehanone commented 9 months ago

@bschonec , thanks for offering to take care of this module. Perhaps, I would consider that in the future. At this point however, I am happy to give you the commit access. However, there needs to be a plan for these 2 issues first:

I would add these two as issues for this modules. I feel a bit reluctant to merge PRs without a successful test harness and I struggle to update PDK templates to later versions So any help in this regard would a great help.

bschonec commented 9 months ago

I don't think the Voxpupuli team cares about the Puppet PDK. In fact, I think they avoid it and develop tests only with Github actions now. I know next to nothing about writing tests but I am pretty sure that they stay away from the PDK.

rehanone commented 9 months ago

Yes I guess that makes sense because I do remember reading somewhere that PDK has been deprecated. I guess in that case the test just needs to be migrated to some framework that allows some sort of testing for this module

bschonec commented 8 months ago

Resolved by #40