search

rehanvdm / serverless-website-analytics

A CDK construct that consists of a serverless backend, frontend and client side code to track website analytics
GNU General Public License v2.0
162 stars 11 forks source link

Browser and OS tabs are disabled #42

Open tomharvey opened 10 months ago

rehanvdm commented 10 months ago

This is because we don't store that data yet. It would have to be added here. Within that function you can extract the OS and Browser in similar ways.

The bigger question is whether these two fields are actually worth storing. I know I don't use that data, but knowing the OS and Browser does not add ad a lot of value to me. But others might find this useful? The idea is to not just track every variable that we possibly can because it will inflate the record size. So I only want to track what brings value.

I intentionally made them disabled to see if someone queries about them like now :)

So if you feel that these stats are useful, by all means, submit a PR. Or let's wait to see if others would also like/find int useful. But for now, this is lower down on the priority list.

tomharvey commented 10 months ago

Honestly, not sure I would use them either :) Just wondering why they were disabled.

rehanvdm commented 10 months ago

Let's actually leave this open. Anyone that wants to see this please +1.

Otherwise, I think we should remove those 2 tabs and replace with "Humans VS. Bots". Because we do have that metric and I have been wanting to surface it. Maybe just the same as the others. so a table, or a donut chart.

rehanvdm commented 10 months ago

This is the ticket for that #3