search

rehanvdm / serverless-website-analytics

A CDK construct that consists of a serverless backend, frontend and client side code to track website analytics
GNU General Public License v2.0
162 stars 11 forks source link

chore: Remove unused package aws-lambda #88

Closed astuyve closed 3 months ago

astuyve commented 3 months ago

The aws-lambda package is a poorly-named CLI tool, and not actually types for AWS Lambda events. https://www.npmjs.com/package/aws-lambda

This PR removes the unused dev dependency. This project already has @types/aws-lambda so no other code changes should be necessary.

astuyve commented 3 months ago

@rehanvdm it looks like we're missing an implicit test dependency on the aws-sdk v2 which was being provided by this library? https://github.com/rehanvdm/serverless-website-analytics/blob/main/tests/application/helpers.ts#L2

I can add it

rehanvdm commented 3 months ago

:face_palm: I have no idea how that got there, probably copy-pasta thanks.

Can you just add aws-sdk for me? It seems that it was using the aws-sdk installed from that package, then the test should pass

astuyve commented 3 months ago

@rehanvdm no problem, all set!

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: