search

rehosting / linux_builder

0 stars 1 forks source link

Improve config modification and lint instructions #6

Closed be32826 closed 9 months ago

be32826 commented 9 months ago
AndrewFasano commented 9 months ago

Thanks, I like this. One thing I was seeing with armeb and mips64el - it doesn't seem like building for those targets actually does anything. Maybe I had something set up wrong on my machine? But that's why the mips64el config had some non-linted options and wasn't included in the default list.

be32826 commented 9 months ago

One thing I was seeing with armeb and mips64el - it doesn't seem like building for those targets actually does anything.

Apparently it's because the build fails because our kernel version is too old (or our gcc version is too new). This is the relevant upstream commit we're missing: https://github.com/torvalds/linux/commit/bee20031772af3debe8cbaa234528f24c7892e8f.

AndrewFasano commented 9 months ago

Gotcha, so we should cherry-pick that commit over to our 4.10 kernel and then merge this?

be32826 commented 9 months ago

Gotcha, so we should cherry-pick that commit over to our 4.10 kernel and then merge this?

Yeah, that's a good plan.