search

rehypejs / rehype-minify

plugins to minify HTML
https://unifiedjs.com
MIT License
89 stars 16 forks source link

Collapse whitespace more safely #27

Closed stevenvachon closed 5 years ago

stevenvachon commented 5 years ago

... with normalize-html-whitespace instead of collapse-white-space.

ChristianMurphy commented 5 years ago

Nice! @stevenvachon have you run into an edge case that you could share where collapse-white-space caused an issue? I'm also mildly concerned with replacing a SemVer stable library (collapse-white-space is at version 1.0.4) with a library that is SemVer unstable (normalize-html-whitespace is at version 0.2.0). Is there a stable release planned?

stevenvachon commented 5 years ago

I haven't yet used this library, but will be deciding between it, reshape and posthtml in the future. I'd just like for them all to benefit from my work. There're no plans for a 1.x, but there're also no plans for breaking changes. Perhaps a 1.x is due after such a long wait (for bug reports) in 0.x

v1.0.0 is now published.

wooorm commented 5 years ago

@stevenvachon Interesting aside: the timestamps are weird btw! Something up with your computer? screenshot 2019-02-25 at 9 13 30 am

I haven't yet used this library, but will be deciding between it, reshape and posthtml in the future. I'd just like for them all to benefit from my work

Alright. Well, I’m up for using your project over collapse-white-space, but I’d appreciate a PR with tests !

stevenvachon commented 5 years ago

the timestamps are weird btw! Something up with your computer?

Force-pushes will do that.

I’d appreciate a PR with tests

I'll see what I can do.

wooorm commented 5 years ago

Feel free to ping back here when you can, we’d appreciate the tests. But for now I’m closing this.

stevenvachon commented 5 years ago

So, it's not important to have correct logic unless you don't have to do it yourself?

wooorm commented 5 years ago

So, it's not important to have correct logic unless you don't have to do it yourself?

I think it’s important that you understand that I’ve spent a lot of time already on these projects and that the version you get is my gift to you. It’s just that changes should come with a test. You can read more about the rights you have in the license.

stevenvachon commented 5 years ago

I have no rights. I questioned your dedication to quality.