rehypejs / rehype-minify

plugins to minify HTML
https://unifiedjs.com
MIT License
89 stars 16 forks source link

rehype-minify-whitespace: make json require explicit #29

Closed tokiedokie closed 5 years ago

tokiedokie commented 5 years ago

I had an error about resolving file

ERROR in ./node_modules/rehype-minify-whitespace/index.js
Module not found: Error: Can't resolve './list'

So, I fix filename.

require json file, filename should *.json

var list = require('./list)var list = require('./list.json')

codecov-io commented 5 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          76     76           
  Lines        1121   1121           
=====================================
  Hits         1121   1121
Impacted Files Coverage Δ
packages/rehype-minify-whitespace/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b253fd0...fb0c24a. Read the comment docs.

wooorm commented 5 years ago

This is mostly a problem with how you configure your build tools. You can find some answers e.g. by searching like so

wooorm commented 5 years ago

Thanks @tokiedokie, released!