search

rehypejs / rehype-minify

plugins to minify HTML
https://unifiedjs.com
MIT License
90 stars 16 forks source link

rehype-minify-whitespace: fix missing return tree #33

Closed kptdobe closed 4 years ago

kptdobe commented 4 years ago

Potential fix following up changes introduced by https://github.com/rehypejs/rehype-minify/issues/19

The current code does not work in the hast-util-to-mdast context.

codecov-commenter commented 4 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         1205      1209    +4     
=========================================
+ Hits          1205      1209    +4
Impacted Files Coverage Δ
packages/rehype-minify-whitespace/index.js 100.00% <100.00%> (ø)
packages/rehype-minify-whitespace/test.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 391a00e...b422444. Read the comment docs.

wooorm commented 4 years ago

Thanks! But that isn’t really a problem here. Transformers don’t need to return a tree. It’s more an issue with hast-util-to-mdast depending on it!