rehypejs / rehype-minify

plugins to minify HTML
https://unifiedjs.com
MIT License
90 stars 16 forks source link

rehype-remove-script-type-javascript: add example of `type="module"` #42

Closed j-f1 closed 2 years ago

j-f1 commented 2 years ago

Initial checklist

Description of changes

This adds a test (and an example in the README) to confirm that the type property of <script type="module">...</script> is preserved by rehype-remove-script-type-javascript. When reading through the README for this package, my immediate concern was that inline module scripts would be converted to regular scripts, so hopefully this change will assuage that concern for future visitors. Also, the test makes sure there won’t be a regression here.

wooorm commented 2 years ago

Thanks Jed!

github-actions[bot] commented 2 years ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.