rehypejs / rehype-minify

plugins to minify HTML
https://unifiedjs.com
MIT License
90 stars 16 forks source link

feat: rehype-remove-images #47

Closed iloveitaly closed 1 year ago

iloveitaly commented 1 year ago

Initial checklist

Description of changes

Simple plugin to remove images from HTML.

The typing syntax feels strange compared to normal typescript, so the build is failing. Before digging further, I wanted to submit a draft PR to see if this is something you'd like to include in the package.

If you could point me in the right direction to fix up the TS issues / understand the new TS syntax I', seeing here I'd be grateful.

github-actions[bot] commented 1 year ago

Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.

You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done!

If you need it, here’s the original template ```markdown ### Initial checklist * [ ] I read the support docs * [ ] I read the contributing guide * [ ] I agree to follow the code of conduct * [ ] I searched issues and couldn’t find anything (or linked relevant results below) * [ ] If applicable, I’ve added docs and tests ### Description of changes TODO ```

Thanks, — bb

iloveitaly commented 1 year ago

@wooorm this PR isn't ready yet, but I'm curious if you could point me in the right direction to fix up this PR.

iloveitaly commented 1 year ago

@wooorm thanks for the helpful response!

Do you think I should just pull this into a separate repo, or would you be open to including it here if the issues were fixed?

wooorm commented 1 year ago

The former, as of yet I don’t feel like it fits here, but maybe you have good reasons to say it is useful to just minify without side-effects for most folks (opt-in or not). So, make your own repo, PR to add it to the list of plugins, and ask for a review on tips! (or feel free to open discussions earlier!)

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.