search

reibitto / sbt-welcome

An SBT plugin for displaying a welcome message and commonly used tasks.
Apache License 2.0
81 stars 4 forks source link

fix: register custom alias provided by the user if present #9

Closed kpodsiad closed 1 year ago

kpodsiad commented 1 year ago

fixes https://github.com/reibitto/sbt-welcome/issues/8, although I'm not sure what exactly semantic of auto alias should be and if my fix is not breaking other things. Unit tests are passing but maybe it'll be worth to have scripted test to see if aliases are working?

kpodsiad commented 1 year ago

I'm actually not sure how to write an integration test for sbt plugins and check its internal state, but I could at the very least add a test to make sure the sbt command in the data structure is correct. The only tests that currently exist test the rendering.

I have some experience with scripted tests, I can take a look and try to write one. I think internal state doesn't need to be inspected, all what we need to check is if an alias invokes a command and doesn't result in error instead.