search

reichlab / Covid-19-Hub-Vizualization

2 stars 3 forks source link

Artifacts in polygons #47

Closed sbfnk closed 3 years ago

sbfnk commented 3 years ago

Should Truth data be a radio button perhaps?

Example (reproduce by unselecting truth data and using right/left cursor keys to navigate to the date): image

nickreich commented 3 years ago

Truth data should not be a radio button, you often want to see both. That is, what is available right now (latest available data) and what was available as of the time forecasts were made. I still can't reproduce your artifact.

nickreich commented 3 years ago

This is what I see image

sbfnk commented 3 years ago

Ah that makes sense re radio buttons.

One year earlier?

nickreich commented 3 years ago

Got it, thanks! This is not tied to the truth data being shown or not, but to something else about the polygon construction... image

nickreich commented 3 years ago

@vrushti-mody I'm specifically NOT adding a "before-publicizing" label to this. I think this is fringe enough that we don't need to delay release. but does seem like something we want to address.

nickreich commented 3 years ago

Of note, it doesn't seem to be an issue for all models. It might only imapact the ensemnble, actually. image

vrushti-mody commented 3 years ago

I think its because the extra line that we are plotting to join the visualisation with the current truth takes the last point of the truth date and first point of the viz model date. If the model dates are descending, it becomes a problem. I'll sort the dates and the issue should be resolved

elray1 commented 3 years ago

Noting that if we sort the dates, we should be sure to also sort the corresponding quantiles along with them.

vrushti-mody commented 3 years ago

I think the issue is fixed now. Closing this for now