reichlab / forecast-repository

Codebase for Zoltar forecast repository
https://zoltardata.com/
GNU General Public License v3.0
6 stars 3 forks source link

delete Zoltar forecasts that were deleted from github #308

Closed matthewcornell closed 3 years ago

matthewcornell commented 3 years ago

The forecasts in this sheet were deleted from github, but not from zoltar: COVIDhub-deleted-forecasts. They were deleted from the repo b/c they only forecasted these two targets that were dropped in summer: 'day ahead inc death' and 'day ahead cum death'.

Points:

matthewcornell commented 3 years ago

I wrote a script that analyzed the sheet's forecasts, and I've attached the output. Results:

mc-0429-deleted-forecasts.csv

matthewcornell commented 3 years ago

Additional details from @nickreich:

matthewcornell commented 3 years ago

Here's the latest output of what the script would do. Notes:

I have not actually run the script yet. If the attachment looks OK, I'll run it locally, then back up production and run it there.

mc-0430-deleted-forecasts.csv

matthewcornell commented 3 years ago

I ran the script (attached) against production, and spot-checked the new forecasts (IDs are at the bottom of the attached output file) - they all look fine to me, but please double-check.

issue_308_app.py.txt issue_308_app-out.txt

matthewcornell commented 3 years ago

Script had a bug. I added it plus tests to a new branch and then ran on staging. Output attached. mc-0503-staging.csv mc-0503-staging-out.txt

matthewcornell commented 3 years ago

Script was not calling the metadata cache code correctly. Attached has results of a staging run. Looks ok to me, including the previous troublesome one:

mc-0504-staging.csv

nickreich commented 3 years ago

looks good to me too! I looked at some other empty v2 forecasts and they looked correct as well.