consider removing the step where we add noise to the provided quantiles

reichlab / idforecastutils

utility functions for various forecasting models, exercises, and rounds

0 stars 0 forks source link

consider removing the step where we add noise to the provided quantiles #2

Closed elray1 closed 7 months ago

elray1 commented 7 months ago

looking at these lines: https://github.com/reichlab/idforecastutils/blob/b137497b0bbe8c59210dcecb37214ad133740d52/R/get_pmf_forecasts_from_quantile.R#L72-L79

I think we don't need this. Maybe we should double check that after taking these lines out, everything still works ok if there are repeated quantiles (a point mass)

lshandross commented 7 months ago

Function works fine without these lines even with repeated quantiles