search

reichlab / zoltr

http://reichlab.io/zoltr/
GNU General Public License v3.0
2 stars 4 forks source link

Versioning broken #51

Closed sbfnk closed 1 year ago

sbfnk commented 1 year ago

zoltr seems to have gone from version 0.99 to 0.9.10, i.e. a decrease. This breaks installation of the covidHubUtils package.

matthewcornell commented 1 year ago

Sorry about that, Sebastian! From what I've read, version numbers are not supposed to be treated as fractions, but I guess R disagrees. I'll change zoltr to 1.0 and push this am.

matthewcornell commented 1 year ago

@sbfnk Where did you see that the version decrease caused the problem? In the output you link to, I only see this error:

Error: Package required and available but unsuitable version: ‘zoltr’ Imports includes 25 non-default packages. Importing from so many packages makes the package vulnerable to any of them becoming unavailable. Move as many as possible to Suggests and use conditionally. See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’ manual.

sbfnk commented 1 year ago

First line in the bit you pasted.

matthewcornell commented 1 year ago

I just pushed a change to zoltr to implement #50 , and I bumped the version to 1.0.0. Hopefully your recent PR will continue to work. Please let us know. thx