Closed petergoldstein closed 1 year ago
Would this approach make it easier? Sidekiq::VERSION.to_i >= 7
?
Typically you would do something like Gem::Version.new(Sidekiq::VERSION) >= Gem::Version.new("7")
. That ensures the version strings are properly compared, and you don't need to worry about the details.
Description of changes
Fixes the broken build/functionality for Ruby 2.5 and 2.6. The use of 2.7+ syntax in
lib/rails_semantic_logger/engine.rb
breaks this library when used with those Rubies.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.