search

reidmorrison / rails_semantic_logger

Rails Semantic Logger replaces the Rails default logger with Semantic Logger
https://logger.rocketjob.io/rails
Apache License 2.0
320 stars 114 forks source link

fix: remove undef :broadcast since ActiveSupport::Logger dropped it #194

Closed Amnesthesia closed 10 months ago

Amnesthesia commented 11 months ago

Issue # (if available)

Rails 7.1 dropped this method from ActiveSupport::Logger so trying to undefine it throws on boot

Description of changes

Removed that one undef line

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

camsteffen commented 11 months ago

Fixes #191

vishalzambre commented 10 months ago

working for us https://github.com/reidmorrison/rails_semantic_logger/pull/194/files#r1363832270 need to wait for next rails release that includes rails/rails#49621

This is merged

severinkaelin commented 10 months ago

We're running this branch (Amnesthesia:fix/rails7.1) with the 7-1-stable one of rails in production. No issues so far. Thanks a lot for the work!

@Amnesthesia @reidmorrison Are there further changes needed from you point of view or can this be merged and released?

Amnesthesia commented 10 months ago

@severinkaelin Hey, nope — we're also running this in production without issues so far, just waiting for this to be merged!

severinkaelin commented 10 months ago

@.severinkaelin Hey, nope — we're also running this in production without issues so far, just waiting for this to be merged!

@Amnesthesia Great to hear! Thanks for confirming.

@reidmorrison Is there an ETA for getting this PR merged and a release cut? Would be great to see this published to RubyGems. Just let me know if I can be of any help. Many thanks.