Swap Active Job log subscriber safely

reidmorrison / rails_semantic_logger

Rails Semantic Logger replaces the Rails default logger with Semantic Logger

https://logger.rocketjob.io/rails

Apache License 2.0

330 stars 117 forks source link

Swap Active Job log subscriber safely #97

Closed prikha closed 4 years ago

prikha commented 4 years ago

Issue #98

At the moment we unsubscribe whoever has subscribed to active_job notifications in the initialization process. Which leads to bugs and frustration. I either haven't seen the log subscriber once submitted the initial PR , or missed it somehow.

Description of changes

We have an opportunity to swap the log subscriber safely.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

reidmorrison commented 4 years ago

Thank you for the pull request.