search

reidmorrison / semantic_logger

Semantic Logger is a feature rich logging framework, and replacement for existing Ruby & Rails loggers.
https://logger.rocketjob.io/
Apache License 2.0
873 stars 124 forks source link

Fix Appenders#close referencing incorrect variable #294

Closed vovimayhem closed 2 months ago

vovimayhem commented 3 months ago

Issue #291

Changelog

Pull requests will not be accepted without a description of this change under the [unreleased] section in the file CHANGELOG.

Description of changes

On 4.16.0, Appenders#close is referencing a non-existant variable appenders instead of closed_appenders, which looks it was left like that by mistake, causing errors when calling SemanticLogger#close_appenders!

This PR includes the fix proposed by @jesseyoungmann on Issue #291

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ixti commented 3 months ago

Alternative PR: #290

ixti commented 2 months ago

This can be closed (via #290)

reidmorrison commented 2 months ago

Fixed with #290