reidmorrison / semantic_logger

Semantic Logger is a feature rich logging framework, and replacement for existing Ruby & Rails loggers.
https://logger.rocketjob.io/
Apache License 2.0
873 stars 124 forks source link

fix: ensure logger debug calls always return true #305

Open gugaiz opened 5 days ago

gugaiz commented 5 days ago

Issue #304

Description of changes

Modify logger debug behavior to return true regardless of the log level, ensuring dependent processes like state machines in solidus function correctly

Context

In Rails’ default logger, a call to logger.debug always returns true regardless of the log level, preserving compatibility with code that relies on the return value. However, rails_semantic_logger deviates from this behavior, returning false when the log level does not allow the message to be logged. This discrepancy can cause unexpected issues in frameworks like Solidus or other applications using state machines or similar logic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.