reifyhealth / lein-git-down

A Leiningen plugin for resolving dependencies from Git
MIT License
82 stars 6 forks source link

Is manifest-root supported for deps.edn? #50

Open vemv opened 2 years ago

vemv commented 2 years ago

Hi!

I have a config like this:

{eftest/eftest
  {:coordinates vemv/eftest, :manifest-root "eftest"}}

where deps.edn is not located at the root of the vemv/eftest repo, but within its eftest folder.

Is that supposed to work? I'm not sure if deps.edn counts as a "manifest file" which makes me hesitate.

Cheers - V

manderson202 commented 2 years ago

Hi, yes, this should be supported for deps.edn as well. Are you encountering any issues with this set up?

vemv commented 2 years ago

Yes, the generated artifact I can find in ~/.m2 lacks any sources, I only see a few meta files

manderson202 commented 2 years ago

Ok, thanks for the report, will leave this open to track

vemv commented 2 years ago

Here's the repo in question (wasn't public before) https://github.com/vemv/eftest