search

reifyhealth / specmonstah

Specmonstah will eat the face off your test fixtures
MIT License
359 stars 18 forks source link

Fix visiting self references #88

Closed mitchkyle-reify closed 1 year ago

mitchkyle-reify commented 1 year ago

When building the dependency for visiting, entities that reference themselves were preventing sorting.

Since we don't actually need to create the entity before we create the entity, I just removed self references when we do the topsort.

codonnell-reify commented 1 year ago

@flyingmachine Would be interested in your thoughts on this if you have time to take a look!

flyingmachine commented 1 year ago

BTW I have been iterating on somewhat large update, forked to https://github.com/donut-power/datapotato. The main point of the update is to make the library more approachable. I've tried to do that by reducing the number of steps required to get things working for most use cases - in particular, providing default insertion helpers for next.jdbc, datomic, and xtdb.

Along the way I've tried to make data gen and insertion first-class citizens. I think the code itself is in pretty decent shape. I'm just going through and updating specs and docs. I'll be demoing the updated library in about a month. If y'all wanted to look at the changes together at some point let me know!

mitchkyle-reify commented 1 year ago

Along the way I've tried to make data gen and insertion first-class citizens. I think the code itself is in pretty decent shape. I'm just going through and updating specs and docs. I'll be demoing the updated library in about a month. If y'all wanted to look at the changes together at some point let me know!

Yeah, I'll check it out! thanks. I know in the projects I work on that uses specmonstah there's always a test ns for gluing it to the database. Hopefully this will cut down on that file.

codonnell-reify commented 1 year ago

BTW I have been iterating on somewhat large update, forked to https://github.com/donut-power/datapotato. The main point of the update is to make the library more approachable. I've tried to do that by reducing the number of steps required to get things working for most use cases - in particular, providing default insertion helpers for next.jdbc, datomic, and xtdb.

Along the way I've tried to make data gen and insertion first-class citizens. I think the code itself is in pretty decent shape. I'm just going through and updating specs and docs. I'll be demoing the updated library in about a month. If y'all wanted to look at the changes together at some point let me know!

Seems like a nice simplification given the intended use case of the library! 💯