reiinakano / fast-style-transfer-deeplearnjs

Demo of in-browser Fast Neural Style Transfer with deeplearn.js library
https://reiinakano.github.io/fast-style-transfer-deeplearnjs
MIT License
1.35k stars 110 forks source link

DemoSite Error - ReferenceError: dialogPolyfill is not defined #6

Closed RexMorgan closed 6 years ago

RexMorgan commented 6 years ago

Getting this error on Firefox 57 (beta) and Chrome 61 on Windows 10.

All of the requests seem to work properly, with adblockers disabled.

All I see is a white page w/ the github logo in the corner.

image

image

reiinakano commented 6 years ago

Okay, looked a bit into this and this piece of code is only run if an unsupported browser is detected, which is one of three cases: mobile or Safari or a non-WebGL enabled browser.

I guess if you're not on mobile or Safari, then your browser doesn't support WebGL and you wouldn't be able to run it either. Sorry!

You can see the warnings on the console confirming your browser does not support WebGL.

RexMorgan commented 6 years ago

@reiinakano thanks. I enabled webgl in firefox and the page loads, now.

Unfortunately the site doesn't work, and I get some webgl errors. I'm assuming that's because webgl was disabled by default for a reason :)

image

For others, I set webgl.force-enabled to true in about:config to enable webgl.

reiinakano commented 6 years ago

You might want to try running the official deeplearn JS demos http://deeplearnjs.org/index.html#demos and see if the same errors pop up.

If they do, then you'll get a better answer by filing an issue there. I am honestly clueless about the internals of the library. I am a mere user, haha. :)

reiinakano commented 6 years ago

This is now fixed in the newest version. You should see a proper error message now if your device is unsupported.