Custom Scorer for CV inside plot_learning_curve

reiinakano / scikit-plot

An intuitive library to add plotting functionality to scikit-learn objects.

MIT License

2.43k stars 284 forks source link

Custom Scorer for CV inside plot_learning_curve #49

Closed jengelman closed 7 years ago

jengelman commented 7 years ago

Issue: #26

Added scoring parameter to plot_learning_curve, which passes to the scikit-learn learning_curve function.

reiinakano commented 7 years ago

Hi @jengelman, thanks for this! Could you add a simple unit test simply to see if the new argument runs with no errors?

jengelman commented 7 years ago

@reiinakano Sure! Wasn't sure if one was necessary since the classifier and regressor unit tests already cover plot_learning_curve, calling it with default params. Can I just add a test for a single non-accuracy (in the classifier tests) and r2 (for the regressor tests) or do you want something more in depth?

reiinakano commented 7 years ago

No need for anything in-depth, what you mentioned is perfectly fine!

reiinakano commented 7 years ago

Merged as I want this as part of a bigger change in v0.3.0

jengelman commented 7 years ago

Sorry for the delay on those tests, excited for the new version!