Closed ljvmiranda921 closed 7 years ago
Hi @ljvmiranda921! Thanks a lot for this great PR! Nothing's wrong with your environment, there's just no released version with the fix for the deprecated colormap yet.
No need to rebase, Github has an option to squash commits upon merge. So far LGTM!
Hi @reiinakano , here's my PR! 👍
This commit solves Issue #62 and updates Jupyter notebook examples to be compliant with the latest version. Some things to note:
Summary
Demos that used the plotters API were removed. Some examples demonstrate by showing how to do it with the factory, and by the
plotters
API. Since both of them are deprecated, I just removed the other and focused on the updated way to do it.__Add a .gitignore file to untrack .ipynb_checkpoints__ I think they're not needed so I have git ignore them.
Explicitly pass a parameter to
cmap
to avoid matplotlib deprecation warning. This seems a bit weird for me. My environment has matplotlib 2.0.2 and of course scikit-plot 0.3.1. When I callplot_roc_curve
orplot_precision_curve
, I encounter a deprecation warning on the use ofspectral
orspectral_r
.So whenever I do this:
This appears:
Although I checked the code in the repo and it's actually supplying
nipy_spectral
. Hmmm, not sure if it's just an environment problem for me. Either way, I solve it by explicitly passing the cmap parameter instead.I committed a lot (almost per file), I can rebase my commits after your suggestion/revisions/review. Thank you so much! Sorry if this PR took me a long time, thesis happened. 😞