search

reikdas / SABLE

1 stars 0 forks source link

Add Github actions CI #27

Open reikdas opened 9 months ago

reikdas commented 9 months ago

Now that we have a minimal test.py file, we can setup a Github actions CI to run it with every PR and push to main.

Pat-Lafon commented 8 months ago

I actually glanced at this since I like making CI stuff. My understanding is that you need to generate matricies first now before running the tests. I'm not sure how long that takes but it probably makes the current testing setup not suitable for CI(unless matricies are checked in)

ulysses4ever commented 8 months ago

I don’t think it takes significant time to generate at least some matrices (I don’t know whether there’s a “blessed” set of matrices, but do CI need to run on the full set even?..). But if it does, you could host them somewhere (e.g. GitHub releases can store arbitrary blobs) and wget them on every CI run (and maybe even cache them via the GitHub action).

reikdas commented 6 months ago

There are a couple of things to do here:

  1. https://github.com/reikdas/SABLE/blob/main/test.py already has a matrix encoded in the VBR format. So we don't need to spend any time generating matrices, and we can easily add this to CI.
  2. One could create a config (https://github.com/reikdas/SABLE/blob/main/scripts/generate_vbr_matrices.sh) that generates only a few VBR matrices and add testing for those to CI.