search

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
395 stars 77 forks source link

Change: Set EnableHighDpiScaling flag for high DPI support #103

Closed quigleyj97 closed 5 years ago

quigleyj97 commented 5 years ago

This is handled at the OS layer by OSX and at the server layer by Wayland, whereas X11 and Windows place the responsibility of scaling on the app. Qt includes a flag to enable high-dpi support trivially, though it causes the app to be unwieldy because it's minimum size is still quite large.

I took a stab at a few other avenues, since it should "just work", but it seems to be pretty deep into the weeds with how Qt layouts work and I don't have enough experience with Qt to resolve them right now.

I don't have access to an OSX device, so I haven't been able to test this on other platforms.

Fixes #101

reilleya commented 5 years ago

Looks good! Could you make this a PR into staging instead of master? (Same thing with the docs)

quigleyj97 commented 5 years ago

Whoops! Done for both.

reilleya commented 5 years ago

Unfortunately, this doesn't seem to work on gnome. Screenshot from 2019-07-20 19-39-49

quigleyj97 commented 5 years ago

Ouch...

Do you think we should hide this behind a platform check? I think there's some deeper issues to resolve in the layout scaling but I'd rather not play cross-platform whack-a-mole...

reilleya commented 5 years ago

Yup, Though all the platform-dependent switch statements are supposed to be in Qt itself I think this might be the best way to proceed until someday if/when someone decides to completely rewrite the UI.