search

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
395 stars 77 forks source link

Ux improvements #109

Closed AstroChuck closed 5 years ago

AstroChuck commented 5 years ago

Users may now double click on grains or a nozzle item in the collection editor to edit the item. Creating a new propellant in the propellant editor now automatically opens the created propellant.

benrussell11 commented 5 years ago

And does double clicking on a row in the propellant editor bring up the propellant edit dialog? Does double clicking on "Config" bring up the config dialog?

We should be able to double click on any row in a grid and have it display the appropriate edit dialog.

When will stage be updated.

Ben

AstroChuck commented 5 years ago

@benrussell11 The way it is implemented, editGrain contains the logic to determine if you've clicked 'nozzle' 'config' or 'grain' so calling editGrain allows you to edit any of them by double clicking them in the collectionEditor. doubleClickEvent is called after a clickEvent which calls a function to change the selection in collectionEditor, so it will always open whatever you clicked, any row. I don't know what the timeline is on updating staging.

benrussell11 commented 5 years ago

That’s great Charlie … thanks for all of your help.

From: Charlie Garcia notifications@github.com Sent: Monday, July 29, 2019 12:01 PM To: reilleya/openMotor openMotor@noreply.github.com Cc: benrussell11 ben.russell11@gmail.com; Mention mention@noreply.github.com Subject: Re: [reilleya/openMotor] Ux improvements (#109)

@benrussell11 https://github.com/benrussell11 The way it is implemented, editGrain contains the logic to determine if you've clicked 'nozzle' 'config' or 'grain' so calling editGrain allows you to edit any of them by double clicking them in the collectionEditor. doubleClickEvent is called after a clickEvent which calls a function to change the selection in collectionEditor, so it will always open whatever you clicked, any row. I don't know what the timeline is on updating staging.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reilleya/openMotor/pull/109?email_source=notifications&email_token=AL4HO6B23AQJWWJ6FMVRKM3QB4H2TA5CNFSM4IHLAV3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BFQJA#issuecomment-516053028 , or mute the thread https://github.com/notifications/unsubscribe-auth/AL4HO6BAQAQTNKDKAIKKF5LQB4H2TANCNFSM4IHLAV3A . https://github.com/notifications/beacon/AL4HO6F2LJCVZQC3IXMDDM3QB4H2TA5CNFSM4IHLAV3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BFQJA.gif

reilleya commented 5 years ago

Could you remove the changes to grainselector and squash this so I can merge it? Alternatively, just make a new commit with only the correct changes, PR it, and I will merge that instead. Thanks!