search

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
390 stars 75 forks source link

Edit > Preferences > Units, Diameter not listed #147

Closed dhbarr closed 4 years ago

dhbarr commented 4 years ago

In Edit > Preferences > Units, I don't find the ability to change Diameter to mm ( most hobby motors are denoted this way ).

reilleya commented 4 years ago

Changing the length setting changes the unit that is used for all fields with units of length, including diameter. If you change length to mm it will change every instance of in to mm. I'm not sure I want to have different units for different fields of the same base unit.

dhbarr commented 4 years ago

It's a good point, I'm not a huge fan of mixed units either -- I notice that .eng and .rse files are both denoted in mm, so maybe just helping the user discover that to change the units for Diameter you need to change the units for Length? And maybe all the places that's used?

Perhaps it's just me, I don't ever think "What's the length of this diameter?"

reilleya commented 4 years ago

Not planning to do this, but I will add unit dropdowns to every field so you don't have to change settings to use a different unit.