search

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
390 stars 75 forks source link

Enable GitHub Actions CI #168

Closed stefanor closed 3 years ago

stefanor commented 3 years ago

Some CI to keep tests passing.

Had to unpin versions in requirements.txt for them to be installable. You may want to have a separate test-requirements, or just script the unpinning in the test job.

reilleya commented 3 years ago

Looks good! One comment but otherwise I think this is ready to merge. I hadn't realized that github has built in CI.

This is another case of something that I should have documented, but there is a pylintrc file checked in that we should have this use if switching it isn't too difficult. If I remember correctly, much of the UI code raises low level warnings while the simulation code is pretty clean.

stefanor commented 3 years ago

I had a look, but can't see an obvious way to do anything useful with pylint.

Pylint gives very granular feedback, so you don't want to use it as a pass/fail check, you rather want something to comment on every line of the MR that generates feedback. I think github actions can do that. But I haven't dug in at that level, and I'm not going to for a drive by PR :)

So, probably simple enough to swap that (stock template) flake8 with a pass/fail pylint. But more than that is more complex.

reilleya commented 3 years ago

Makes sense. I'll into using pylint in the future but this seems good for now.

Thanks!