search

reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
361 stars 71 forks source link

Conical grain type can only have 'Both' inhibited ends option #202

Open chmns opened 2 years ago

chmns commented 2 years ago

On line 20 of conical.py only 'Both' option is listed for the inhibitedEnds property array, leading to the UI only being able to select this.

https://github.com/reilleya/openMotor/blob/9e4d6fd2302f0a78f8453d967b237983e4c383c9/motorlib/grains/conical.py#L20

However in the rest of the code there appears to be sufficient code to calculate the burning for all 4 types (Both, Neither, Top, Bottom), e.g.

https://github.com/reilleya/openMotor/blob/9e4d6fd2302f0a78f8453d967b237983e4c383c9/motorlib/grains/conical.py#L89

reilleya commented 2 years ago

Sorry for the delay! There was some bug with calculating the regression of uninhibited conical grains, so I disabled them temporarily to get the rest of the release out. I would like to fix this, so I'll mark this as a bug to remind myself.