reilleya / openMotor

An open-source internal ballistics simulator for rocket motor experimenters
GNU General Public License v3.0
400 stars 78 forks source link

Build an import/export manager #77

Closed reilleya closed 5 years ago

reilleya commented 5 years ago

As the number of importers and exporters grows, it will become annoying to have them all hardcoded. Build a system similar to the tool manager that handles the flow of information in and out of the importers/exporters that also populates the menu. An example of the benefit is that this will make it easier to automatically run simulations before exporting.

coop44483 commented 5 years ago

Is it possible to import only the propellant info from a BurnSim file. I am the author of ProPep 3 which can create a BurnSim file, but it does not include any grain information. I attempted to import one of my files into OpenMotor but nothing seems to happen.
It would be nice to be able to import just the 7 values needed for a new propellant since some of my user can be a little computer challenged ;). BTW Great Program. Chuck Rogers and I have talked about doing this but I looks like you may have beaten us to the punch!

Dave Cooper

reilleya commented 5 years ago

Hey Dave, I hadn't considered a propellant-only import, but that seems like a good idea that will require almost no effort. I will make an issue ticket for the feature. Thanks! I have used some resources written by Chuck during development and would love to know if he has any ideas for the program, especially about how to simulate or predict erosive burning.

coop44483 commented 5 years ago

How can Chuck contact you? I know he will not use github. Can you send me a private message with your email address? Or you could just contact Chuck using his aol account. (RASAreo has it.)

I will contact him to give him a heads up.

Coop

From: Andrew Reilley [mailto:notifications@github.com] Sent: Tuesday, July 16, 2019 12:18 AM To: reilleya/openMotor Cc: coop44483; Comment Subject: Re: [reilleya/openMotor] Build an import/export manager (#77)

Hey Dave, I hadn't considered a propellant-only import, but that seems like a good idea that will require almost no effort. I will make an issue ticket for the feature. Thanks! I have used some resources written by Chuck during development and would love to know if he has any ideas for the program, especially about how to simulate or predict erosive burning.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/reilleya/openMotor/issues/77?email_source=notifications&email_token=AJDLD62W7PZ33ZNY76RQRPLP7VDX7A5CNFSM4HW26NEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7USJY#issuecomment-511658279 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJDLD62YUDNNDW4TAGBF7M3P7VDX7ANCNFSM4HW26NEA . https://github.com/notifications/beacon/AJDLD67FVCFOCQYNBEY5MSLP7VDX7A5CNFSM4HW26NEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7USJY.gif


This email has been checked for viruses by AVG. https://www.avg.com

reilleya commented 5 years ago

Thanks Coop, I will reach out through to him through his email.

reilleya commented 5 years ago

@coop44483 The latest commit to staging adds support for importing burnsim files that contain only propellant data. I've tested it with a file generated by ProPEP 3 and it seems to work, but let me know if you notice any issues.

coop44483 commented 5 years ago

Wow That was fast. I am currently not trying to keep up with OpenMotor since I have about 4 other projects going. If you would give me a heads up when the new version is out and I will try running some of my data files for more testing. Thanks.

Was Chuck able to help?

Coop

From: Andrew Reilley [mailto:notifications@github.com] Sent: Thursday, August 01, 2019 8:23 PM To: reilleya/openMotor Cc: coop44483; Mention Subject: Re: [reilleya/openMotor] Build an import/export manager (#77)

@coop44483 https://github.com/coop44483 The latest commit to staging adds support for importing burnsim files that contain only propellant data. I've tested it with a file generated by ProPEP 3 and it seems to work, but let me know if you notice any issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reilleya/openMotor/issues/77?email_source=notifications&email_token=AJDLD63VKN67UNSQXY6BNDTQCN47VA5CNFSM4HW26NEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MHNHY#issuecomment-517502623 , or mute the thread https://github.com/notifications/unsubscribe-auth/AJDLD662OQLPKOTBBUNKBADQCN47VANCNFSM4HW26NEA . https://github.com/notifications/beacon/AJDLD64PMAVLVYAB3TCU5BDQCN47VA5CNFSM4HW26NEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MHNHY.gif


This email has been checked for viruses by AVG. https://www.avg.com