reimandlab / ActiveDriverDB

ActiveDriverDB
GNU Lesser General Public License v2.1
12 stars 3 forks source link

long names of genes #103

Closed reimand0 closed 7 years ago

reimand0 commented 7 years ago

Adding long names of genes is great, thanks! couple of comments:

  1. we should add the long name also to the network view. the longer description could be added below the network canvas.

  2. the current long name is isoform specific not gene specific, correct? I think the headline could just have the gene-specific name and below in a smaller font the isoform specific extension. For example,

PTPN11 (NM_002834) - Tyrosine-Protein Phosphatase Non-Receptor Type 11

Isoform 1

krassowski commented 7 years ago

2.Yes, that's correct. Will something like:

PTPN11 (NM_002834) - Protein Tyrosine Phosphatase, Non-Receptor Type 11

Tyrosine-Protein Phosphatase Non-Receptor Type 11 Isoform 1

do the job? Please notice the difference between the gene-specific name and the isoform specific - it's often not only + 'isoform X' in isoform name, hence it may be difficult to implement it exactly as in your example (some genes have isoforms indexed by numbers some by letters some don't have at all).

reimand0 commented 7 years ago

Yes that sounds ok

Jüri

On Jul 12, 2017, at 13:57, krassowski notifications@github.com wrote:

2.Yes, that's correct. Will something like:

PTPN11 (NM_002834) - Protein Tyrosine Phosphatase, Non-Receptor Type 11

Tyrosine-Protein Phosphatase Non-Receptor Type 11 Isoform 1

do the job? Please notice the difference between the gene-specific name and the isoform specific - it's often not only + 'isoform X' in isoform name, hence it may be difficult to implement it exactly as in your example (some genes have isoforms indexed by numbers some by letters some don't have at all).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

krassowski commented 7 years ago
  1. Did you mean to add the full summary box to network view, like this:

screenshot from 2017-07-19 22-41-02?

  1. Done
reimand0 commented 7 years ago

This looks good, thanks.

slightly off-topic but the screenshot shows it well: we should change the color of the text of Disorder bar to black or something that shows well on red and gray. The current version can be difficult to read.

krassowski commented 7 years ago

I added the summary box and changed color of disorder text to black (1f92cd27cddb4ca86145809418c3f8682f0b31bf). I will close the issue for now. In case of future requests please reopen.