search

reimandlab / ActiveDriverDB

ActiveDriverDB
GNU Lesser General Public License v2.1
12 stars 3 forks source link

search bar? #108

Closed reimand0 closed 6 years ago

reimand0 commented 6 years ago

is the main search bar on the front page different from the search bar in the top right corner? it would be the best that the topright bar supports the same flexible search as the main bar (mutations in dna and protein, gene symbols, refseq ids, pathways). is this easy to achieve?

krassowski commented 6 years ago

I made the top-right search bar to use exactly the same logic as the main bar. The pathways searching is not implemented yet (generally, neither of search bars supports its yet) but it should be easy to add.

For the top-right bar: do we want to expand width of the bar with results so badges indicating mutations and isoform status display nicely in one line or do we want to hide those badges in top-right quick search results?

reimand0 commented 6 years ago

I think we can expand it a bit however we should keep some minimum screen width in mind. fitting all examples is not a priority.

On Fri, Jul 14, 2017 at 6:32 PM krassowski notifications@github.com wrote:

I made the top-right search bar to use exactly the same logic as the main bar. The pathways searching is not implemented yet (generally, neither of search bars supports its yet) but it should be easy to add.

For the top-right bar: do we want to expand width of the bar with results so badges indicating mutations and isoform status display nicely in one line or do we want to hide those badges in top-right quick search results?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/reimandlab/ActiveDriverDB/issues/108#issuecomment-315483360, or mute the thread https://github.com/notifications/unsubscribe-auth/ASYC_ZwjlA-hm3wmlO7PoVlZCBi8OQ8Cks5sN-yRgaJpZM4OYrBj .

krassowski commented 6 years ago

Already fully implemented.