reimandlab / ActiveDriverDB

ActiveDriverDB
GNU Lesser General Public License v2.1
12 stars 3 forks source link

ClinVar variation != "single nucleotide variant" in ADDB 2019+ #169

Open krassowski opened 3 years ago

krassowski commented 3 years ago

While addressing some automated code complexity warnings over on #168 I noticed that the check for variation_type for ClinVar is correctly executed but there is no following continue instruction that would lead to filtering out non-SNV variants:

https://github.com/reimandlab/ActiveDriverDB/blob/5e9d2c370f9a2609d95283b90a56385a836f084a/website/imports/mutations/clinvar.py#L257-L261

However, it appears likely that they are not included either way, because there is another filter earlier in the pipeline, when the mutations are mapped with annovar:

https://github.com/reimandlab/ActiveDriverDB/blob/cc4873af2f839a37b4e8fd5b6aa4781f1cef38db/website/data/mutations/annotate_clinvar.sh#L10

It would be good to investigate this further. For now, I will add a TODO note in the code to highlight this issue.