search

reinterpretcat / utymap

Highly customizable library for procedural world generation based on real map data
Apache License 2.0
958 stars 151 forks source link

Crash bug when loading too many tiles #121

Closed KingsleyStephens closed 6 years ago

KingsleyStephens commented 6 years ago

Evaluating UtyMap in Unity I am running into a crash bug when loading too many tiles. I am modifying your map demo to use a perspective first person camera and loading tiles that are in the camera frustum. However there is a persistent crash bug that makes the demo unstable. I am happy to provide my source code modifications if you like.

reinterpretcat commented 6 years ago

I saw some crashes once I added mesh caching optimization which can be disabled. However, if it is disabled, then average tile loading time is increased.

I think the issue can be reproduced with existing Map scene, but it would be nice to have some demo scene with first person camera. Could you please create a pull request?

KingsleyStephens commented 6 years ago

I have created a branch off your master and created a demo that reproduces the bug. I have just started using GitHub so am unfamiliar with how to create a pull request. I am assuming I will need to be a member of your repository to push my branch, after which I can then create the pull request?

On 5 October 2017 at 20:12, Ilya Builuk notifications@github.com wrote:

I saw some crashes once I added mesh caching optimization which can be disabled. However, if it is disabled, then average tile loading time is increased.

I think the issue can be reproduced with existing Map scene, but it would be nice to have some demo scene with first person camera. Could you please create a pull request?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/reinterpretcat/utymap/issues/121#issuecomment-334407253, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBkQCe7fuoU9crWJtuxXR0MzCH9SQ0Rks5spJ17gaJpZM4PufUB .

reinterpretcat commented 6 years ago

No, you don't need to be a member: you submit it and then I review it. Check instructions here: https://help.github.com/articles/creating-a-pull-request/

reinterpretcat commented 6 years ago

Please check ThirdPerson scene: I did some changes in core library, it seems a little bit more stable now

KingsleyStephens commented 6 years ago

Thank you for your update. It looks like we will be using MapBox for this particular project now.

On Mon, 16 Oct 2017 at 1:12 am, Ilya Builuk notifications@github.com wrote:

Please check ThirdPerson scene: I did some changes in core library, it seems a little bit more stable now

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/reinterpretcat/utymap/issues/121#issuecomment-336714226, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBkQHplYRZvbBhSZog4WG2Gtx2xyPIHks5sshLcgaJpZM4PufUB .