search

reiseburo / hermann

A gem providing cross-platform Kafka producer and consumer support
MIT License
71 stars 76 forks source link

use semantic versioning for jar-dependency runtime dependency #120

Closed mkristian closed 9 years ago

rtyler commented 9 years ago

@mkristian doesn't hermann require a jar-dependencies of at least a certain baseline version? I think we had some bug fixes go into 0.1.12-0.1.15 that were required for hermann to work properly

mkristian commented 9 years ago

not that I am aware of. 0.1.15 was the last one. probably safe to add a '>= 0.1.12' with the semantic part.

mkristian commented 9 years ago

now I need to squash those two commits.

mkristian commented 9 years ago

@rtyler squashed and now semantic version with baseline version

rtyler commented 9 years ago 
Illformed requirement ["=> 0.1.10"] from
  /home/travis/build/lookout/hermann/hermann.gemspec:36:in `eval_gemspec'

Interesting that only one of the versions of Ruby fails with that

mkristian commented 9 years ago

only jruby does include the jar-dependencies dependency so only one failed :)

rtyler commented 9 years ago

@mkristian heh, right you are, I only quickly glanced at this yesterday and clearly didn't read anything