search

reiseburo / hermann

A gem providing cross-platform Kafka producer and consumer support
MIT License
71 stars 76 forks source link

mri, initial offsets #95

Closed osheroff closed 9 years ago

osheroff commented 9 years ago

allow the consumer to choose an initial offset position on mri. this can be either :start, :end, or a fixnum position. would do the same for the jruby client if it was thought valuable, but I'd need to go poke into the interface.

rtyler commented 9 years ago

After this change is merged, I'll cut a new release to rubygems.org since my magic auto-deploy stuff isn't entirely working correctly

osheroff commented 9 years ago

updated, thanks for the review!

osheroff commented 9 years ago

yup, sorry. fixed now.

rtyler commented 9 years ago

0.23.242 contains this change

osheroff commented 9 years ago

awesome, thanks much @rtyler