search

reiseburo / verspaetung

Verspätung is a small utility which aims to help identify delay of Kafka consumers
http://reiseburo.github.io/verspaetung/
MIT License
11 stars 2 forks source link

Broker watcher refactor #37

Closed mkristian closed 8 years ago

mkristian commented 8 years ago

@rtyler this is meant to be the first refactoring. the idea was/is to have only one treeWatcher which uses the switch to dispatch the events on three different implementations - broker, standard, spout

the implementation get picked by the base-path if the event.

unfortunately I did not get the ok to proceed here and I am not sure if I find "free" time to finish it.

anyways with this patch brokers can come and go anytime now. the same is needed for consumers and probably topics to have Maps and Sets grow and shrink over time and reflect the current status of the system.

rtyler commented 8 years ago

@mkristian understood on the time constraint thing, I'll take a look at this closer to the end of the week when my schedule permits :)

Thanks!

rtyler commented 8 years ago

@mkristian I released this as 0.6.0 btw