search

reisepass / ETHz_HeadlineGenerator

NLP 2013 INF.ETHz
2 stars 0 forks source link

Out of bounds in FeatureBasedSummary.getTopEntity() #20

Open reisepass opened 11 years ago

reisepass commented 11 years ago

in Feature Based Summary in the getTopEntity() method.

we get a out of bounds exception here

line 85 if (subjectEntities.contains(entry)) { subjectEntities.get(objectEntities.indexOf(entry)).occurences++; }

because objectEntities.indexOf(entry) returns a -1 when with an entity "O" occurance 1

OOOO you did some copy pasta here and forgot to change somethign.

I am going to change it to this:

if (subjectEntities.contains(entry)) { subjectEntities.get(subjectEntities.indexOf(entry)).occurences++;

jarednieder commented 11 years ago

Perfect, I ran into that error but didn't commit the fix, so I'll just merge with your fix. On May 19, 2013 12:04 PM, "Mortiffer" notifications@github.com wrote:

in Feature Based Summary in the getTopEntity() method.

we get a out of bounds exception here

line 85 if (subjectEntities.contains(entry)) { subjectEntities.get(objectEntities.indexOf(entry)).occurences++; }

because objectEntities.indexOf(entry) returns a -1 when with an entity "O" occurance 1

OOOO you did some copy pasta here and forgot to change somethign.

I am going to change it to this:

if (subjectEntities.contains(entry)) { subjectEntities.get(subjectEntities.indexOf(entry)).occurences++;

— Reply to this email directly or view it on GitHubhttps://github.com/rubenwolff/ETHz_HeadlineGenerator/issues/20 .

reisepass commented 11 years ago

Have made a bunch of changes. been to afraid to commit. Tell me when you want to sync up. If i am very carefull with the ignore list it should be ok right ?