search

reisxd / revanced-builder

A NodeJS ReVanced builder
GNU General Public License v3.0
1.93k stars 172 forks source link

**Non-recommended version selected** #681

Closed Broukmiken closed 1 year ago

Broukmiken commented 1 year ago

Hello, No recommanded version (yt 18.05.40 for real) appears in the list given the oldest that appears is 18.08.35. So, we can't find the recommanded version. i tryed many web browsers and Computers and it's the same issue. can you have a look on it or give me an advice ? thanks

imaperson1060 commented 1 year ago

Just get the apk from https://www.apkmirror.com/apk/google-inc/youtube/youtube-18-05-40-release

Broukmiken commented 1 year ago

Hello, thanks for the advice, it works ! Do you think it the given list will have more range in the next update ?

imaperson1060 commented 1 year ago

No. The way the selection screen works is it looks at the most recent releases (first page of results) of YT on ApkMirror, and lists them. Unless the code is updated to scrape multiple pages. A useful feature would be a button at the bottom to "View more releases" and linking to the ApkMirror page.

Grod56 commented 1 year ago

I really don't get the point of just listing the most recent apks regardless of whether recommended version is available or not. It just seems like a recipe for bugs down the line, as I'm sure a decent number of people would just select a random version instead of scouring the internet for the recommended apk. Previous versions used to include the recommended version, I don't know why that feature was removed in more recent iterations of this app.

imaperson1060 commented 1 year ago

Because the patches weren't updated for so long the recommended version doesn't appear on the first page of results on ApkMirror. The feature actually wasn't changed at all. And the app throws a warning when you try to use an unrecommended version. If you feel that strongly, make a pull request for scraping multiple pages of results.

Broukmiken commented 1 year ago

@imaperson1060 thank you for all thoses explanations. it's not that hard to download ourself the good apk. Perhaps next update will integrate like you said multiple pages of results. Wait and see.

imaperson1060 commented 1 year ago

I made a PR with the page navigation (#686). Hopefully it will be approved :)

Download binaries: https://github.com/imaperson1060/revanced-builder/releases/tag/v3.9.0-pages

Screenshot_20230418-102856.png Lessgo