search

reitzig / sdkman-for-fish

Adds support for SDKMAN! to fish
MIT License
280 stars 13 forks source link

If sdk is not already installed it could install it or provide instructions #26

Closed jasperblues closed 4 years ago

reitzig commented 5 years ago

Could you please elaborate on the use-case you have in mind? Why would one install this before SDKMAN! itself?

jasperblues commented 5 years ago

Brand new mac. Installed fish shell. Installed fisher. Needed a Java tool, so installed sdkman-for-fish - expected it to 'just work', however it didn't. Took a moment to figure out why. I don't think it was unreasonable to expect, like a package manager, that the tool would install sdkman itself as a 'transitive dependency', though of course it makes sense why it didn't.

reitzig commented 5 years ago

As confusing (and flattering) it is to me that one would find a mere helper script before the real thing, I see your point.

I'll see what I can do. Since installation is as easy as running

curl -s "https://get.sdkman.io" | bash

it seems very feasible to install SDKMAN! if missing (after user confirmation).

jasperblues commented 5 years ago

Nice!

tonsV2 commented 4 years ago

Google brought mere. I didn't have sdkman installed and it also took me some time to figure out that I needed to install it myself. And also that I had to rerun "fisher add reitzig/sdkman-for-fish" again afterwards.

reitzig commented 4 years ago

I changed the language in README to manage expectations.

I also added a simple call to the SDKMAN! installer, so to speak, to function sdk that can be run if SDKMAN! is not yet installed.

And also that I had to rerun "fisher add reitzig/sdkman-for-fish" again afterwards.

That should never be necessary. You do have to open a new shell, though. That's true when using SDKMAN! in bash, so "as intended" (I guess). (I tried source-ing the sdk.fish files after installation of SDKMAN! but that didn't work. PRs welcome.)