search

reitzig / sdkman-for-fish

Adds support for SDKMAN! to fish
MIT License
280 stars 13 forks source link

Changed fisher_data path and `rm` command #37

Closed jsmitley closed 1 year ago

jsmitley commented 3 years ago

Moved fisher_data path from .config to .local/share to match latest fisher release Changed rm to command rm so it doesn't try to use a fish rm function

reitzig commented 3 years ago

We should probably use XDG variables like fisher. :thinking:

Will look at this when I next touch the project. Won't be tomorrow, sorry. Thanks for the ping!

jsmitley commented 3 years ago

Good point, I made that change now. Please look when you have a chance. Thanks!

rmartine-ias commented 2 years ago

Changing rm to command rm also fixes the issue I'm having, where I aliased rm to rm -i. Was seeing something like this every time I ran sdk help:

rm: remove regular file '/var/folders/ht/q8z65bc15mx7gfzx5t3s7_mr0000gq/T/tmp.jFun2SabOO'?

reitzig commented 1 year ago

Sorry for the long silence.

Moved fisher_data path from .config to .local/share to match latest fisher release

Somehow, only a README change is left on this PR. I can't seem to remember what this part was about. Is there still an issue?

Ah, got it. This is about the line that sets __fish_sdkman_noexport_init. The path I hard-coded there was based on where fisher 3 installed plugin sources; fisher 4 uses the config dir of fish directly, unless overridden. We now use their code to determine where to put the auxiliary script. Thanks for the pointer, even though I didn't end put merging your PR! :pray: