sdkman_auto_env=true not working

reitzig / sdkman-for-fish

Adds support for SDKMAN! to fish

MIT License

280 stars 13 forks source link

sdkman_auto_env=true not working #38

Closed jantobola closed 3 years ago

jantobola commented 3 years ago

When sdkman_auto_env is set to true, sdk is not changed on cd It still requires to manually call sdk env

reitzig commented 3 years ago

I will have to look at this; I'll probably have to completely re-implement that feature as sdk currently is not called automatically from fish.

In the meantime, please consider using direnv as a workaround.

reitzig commented 3 years ago

Proposed solution:

Pick up sdkman_auto_env in $SDKMAN_DIR/etc/config when initializing fish
--> new terminal required after changing the config
If set to true, set up a function with --on-variable PWD that checks for .sdkmanrc and runs sdk env resp sdk env clear.

reitzig commented 3 years ago

I've been having trouble writing tests for this feature. After discussion with the original contributer of the feature to SDKMAN!, I'm still not sure what their intended semantics are, and is seems that the behaviour is different between Bash and zsh.

As such, I may just make a third variant. Still figuring how to write an automated test for it, though.

reitzig commented 3 years ago

Fixed on dev, scheduled for release with 2.0.0.

Note that the feature may be evolving upstream. We'll have to wait and see.

mucahitkantepe commented 2 years ago

@reitzig Thanks for the fix, I just copied this change locally and works fine for me, would be great if you release this!

reitzig commented 2 years ago

Ah yes, sorry for that ... I've been short on free-time (and motivation) for much coding, esp. because some items on the to-do list are a hassle to test. :unamused: And by now, months have gone by and I have to go back and check changelists again. :dizzy_face:

Anyway, FWIW, you can always install the dev branch:

fisher install reitzig/sdkman-for-fish@dev

There's no guarantee, but I try to keep that branch in a working state, if not necessarily terribly consistent regarding what has already been implemented/changed and what hasn't.