reitzig / sdkman-for-fish

Adds support for SDKMAN! to fish
MIT License
280 stars 13 forks source link

[Bug] Cannt find SDKMAN! for vscode terminal, but work for Windows Terminal. #47

Closed 1216892614 closed 3 months ago

1216892614 commented 3 months ago

Somehow when I type sdk in vscode terminal, it always print:

even after I set __sdkman_custom_dir in my fish config. And, when I type y, I can see:

but it's not work. You don't seem to have SDKMAN!... come again when I try sdk after.

What's even stranger is this things only happen on my vscode terminal, I can use sdk in my Windows Terminal.

Environment

I looked at the vscode extensions and only the git extension contributed to the environment variables

1216892614 commented 3 months ago

image image

reitzig commented 3 months ago

There seems to be an issue with VS Code and fish; if VS Code does not load your fish config, there's not a whole lot we can do on our end.

ref: https://stackoverflow.com/q/76627370

Also note that we test neither WSL2 nor your fish version (although I think I run the same on Ubuntu 20.04 LTS, no issues), nor can we support either. I will happily review PRs with tests and necessary changes to make the integration work better in more setups, though!