search

rejas / MMM-MotionDetector

This is a motion detector module for MagicMirror
MIT License
53 stars 11 forks source link

Added user-defined notification, debug switch #37

Closed BrianHepler closed 4 years ago

BrianHepler commented 4 years ago

Okay, I think I have it sorted this time. I added config switches for a user-defined additional notification and a verbose logging option. There's a separate configuration for controlling the monitor. The broadcast notifications are tied to the monitor timeout so it goes off every so often instead of every time the mirror sees something. We may wish to change that based upon user feedback.

Thanks again for the great module!

rejas commented 4 years ago

Please fix the intendation, otherwise the code changes cannot be seen clearly

BrianHepler commented 4 years ago

Hrm. Maybe. I'm on holiday for the week. I'll try to get to it during my spare time.

BrianHepler commented 4 years ago

There you go. That should be a little easier to read.

BrianHepler commented 4 years ago

I took the debug stuff and the restrictive if..else logic out of the node helper. Hope that helps.

BrianHepler commented 4 years ago

I thought I got all of the requested changes in there. What am I missing?

BrianHepler commented 4 years ago

Okay, I made the requested changes. Once more, with feeling.