search

rejectedsoftware / vibenews

Combined web forum and NNTP server implementation for stand-alone newsgroups
GNU Affero General Public License v3.0
44 stars 3 forks source link

Make login tabbing work #12

Closed ghost closed 10 years ago

ghost commented 10 years ago

When you type your email and hit tab, it doesn't jump to the password field, but to the login button, making logging on with the keyboard hard. This sets the tabindex making tabbing from email to password to login to register possible.

(this is my first ever commit/pull, so please point out any mistakes I might have made!)

s-ludwig commented 10 years ago

Thanks for the fix! Only the git history of your fork needs to be cleaned up a little before it can be merged. To do this, if you haven't already, you can add the original repository as a remote "upstream" (and fetch the latest changes from there using -f):

git remote add -f upstream https://github.com/rejectedsoftware/vibenews.git

Then you can run an interactive rebase using git rebase -i --onto upstream/master and set all but the first commit to fixup (leave the first one as pick). This will merge all commits together, reapply the resulting patch to the latest master branch and keeps the commit log message of the first commit.

This is something that can come up quite often when doing pull requests, whenever the pull request gets a little out of date, or when multiple changes were necessary before the request is ready, so it's always good to know this stuff well.

ghost commented 10 years ago

It seems I completely messed this up. Would you mind closing/deleting this pull and I'll create another one?