rejectedsoftware / vibenews

Combined web forum and NNTP server implementation for stand-alone newsgroups
GNU Affero General Public License v3.0
44 stars 3 forks source link

Emit proper error message when a posted article was recognized as spam #8

Closed carlor closed 4 years ago

carlor commented 11 years ago

Edit: Original title: Cannot post from registered account

When I click "Post", I'm redirected to /groups/rejectedsoftware.dub/thread/251/:

500 - Internal Server Error

Internal Server Error

Internal error information:
object.Exception@source/vibenews/controller.d(368): Unknown article id!
----------------
./vibenews(pure @safe bool std.exception.enforce!(bool).enforce(bool, lazy const(char)[], immutable(char)[], ulong)+0x6b) [0x68dcef]
./vibenews(vibenews.controller.GroupRef[immutable(char)[]] vibenews.controller.Controller.getArticleGroupRefs(vibe.data.bson.BsonObjectID)+0x171) [0x5baadd]
./vibenews(void vibenews.web.WebInterface.redirectToThreadPost(vibe.http.server.HTTPServerResponse, immutable(char)[], long, vibe.data.bson.BsonObjectID, vibe.http.status.HTTPStatus)+0x1db) [0x5d0057]
./vibenews(void vibenews.web.WebInterface.showThread(vibe.http.server.HTTPServerRequest, vibe.http.server.HTTPServerResponse)+0x3fb) [0x5cdb9b]
./vibenews(void vibe.http.router.URLRouter.handleRequest(vibe.http.server.HTTPServerRequest, vibe.http.server.HTTPServerResponse)+0x179) [0x5e14b1]
./vibenews(bool vibe.http.server.handleRequest(vibe.core.stream.Stream, immutable(char)[], vibe.http.server.HTTPServerListener, ref vibe.http.server.HTTPServerSettings, ref bool)+0x16b5) [0x5d774d]
./vibenews(void vibe.http.server.handleHTTPConnection(vibe.core.net.TCPConnection, vibe.http.server.HTTPServerListener)+0x143) [0x5d5fd3]
./vibenews(void vibe.http.server.listenHTTPPlain(vibe.http.server.HTTPServerSettings, void delegate(vibe.http.server.HTTPServerRequest, vibe.http.server.HTTPServerResponse)).void doListen(vibe.http.server.HTTPServerSettings, vibe.http.server.HTTPServerListener, immutable(char)[]).void __lambda92(vibe.core.net.TCPConnection)+0x2c) [0x5d294c]
./vibenews(extern (C) nothrow void vibe.core.drivers.libevent2_tcp.onConnect(int, short, void*).void ClientTask.execute()+0x2b8) [0x5ee398]
./vibenews(void vibe.core.core.CoreTask.run()+0xeb) [0x5f79d3]
./vibenews(void core.thread.Fiber.run()+0x2a) [0x74e456]
./vibenews(fiber_entryPoint+0x61) [0x74e369]
[(nil)]
s-ludwig commented 11 years ago

Sorry, this is the "less-than-ideal" user interface of the new spam detector. I really need to some measures to better cope with false positives.I had hoped to be able to defer that a little, but since it occurs for every second post it looks I'll have to bit the bullet and do something.

But your original post at least is visible now and replying should also not produce another false positive.

s-ludwig commented 4 years ago

Closing, as this doesn't occur anymore (spam detector works very reliable and the 500 error also doesn't happen).