search

rejeep / f.el

Modern API for working with files and directories in Emacs
GNU General Public License v3.0
680 stars 68 forks source link

[Bug]: f.el no longer byte-compiles under Emacs 24.5 #125

Open wolfmanx opened 1 year ago

wolfmanx commented 1 year ago

Expected behavior

f.el should properly byte-compile with Emacs 24.5.

Actual behavior

Since commit 7bb1d34, f.el no longer byte-compiles under Emacs 24.5.

The reason for the failure is that pcase does not recognize the 'ATOM UPAT. Since the corresponding `ATOM QPAT is equivalent, the fix is trivial and there is no need to require Emacs 25.

f.el version

master

Emacs version

something else (please specify)

Relevant code or log output

Compiling file /home/sw/.emacs.d/elpa/f-20230116.1032/f.el at Sat Apr  8 19:19:07 2023
f.el:462:1:Error: Unknown upattern `(quote any)'
Phundrak commented 1 year ago

Support for Emacs 24 was indeed removed a few months ago. As it is relatively old (its last update dates from around seven years ago) and I cannot easily test Emacs 24 on my machine, it is not very high on my priority list.

If you think this could be an easy fix, feel free to submit a pull request, including adding back Emacs 24.5 in the CI!

Phundrak commented 8 months ago

Wrong issue reference