Cache result of f-path-separator

rejeep / f.el

Modern API for working with files and directories in Emacs

GNU General Public License v3.0

680 stars 68 forks source link

Cache result of f-path-separator #84

Closed sergv closed 6 years ago

sergv commented 6 years ago

It seems redundant to compute its value more than once.

rejeep commented 6 years ago

Merged, thanks! 👍

rejeep commented 6 years ago

This actually broke the build in Emacs 24.1 and 24.2 with (invalid-function setf). Your branch must have been failing as well? How come we didn't see that? I changed to use setq in this branch (https://github.com/rejeep/f.el/pull/87), let's see how that works out.

sergv commented 6 years ago

Very strange, setf is definitely not a new feature by any means. Perhaps for something like Emacs 22 it might've been controversial, but shouldn't be now. My branch wasn't failing, but I may have looked in the wrong direction all along. Anyway, thanks!