search

rejeep / nvm.el

Manage Node versions within Emacs
40 stars 25 forks source link

Drop dash-functional dependency #20

Closed jscheid closed 3 years ago

jscheid commented 3 years ago

The Dash folks have recently decided to merge dash-functional into dash. The latest version of dash-functional now emits a byte-code compilation warning when it is loaded.

Because package.el lacks a mechanism for specifying any constraints on dependency versions (apart from a minimum version) this means that any package depending on nvm will pick up the latest version of dash-functional and therefore print this warning. This breaks, for example, my package's CI.

This PR solves the problem by upgrading dash and dropping the dash-functional dependency.

jscheid commented 3 years ago

CI seems broken but tests pass in my local env.

rejeep commented 3 years ago

Thanks, I added you as a collaborator, feel free to merge!